Skip to content

[O2B-1462] Extend runs API to include QC flags#1953

Merged
xsalonx merged 28 commits into
mainfrom
xsalonx/export/O2B-1462/all-qc-flag-export
Aug 4, 2025
Merged

[O2B-1462] Extend runs API to include QC flags#1953
xsalonx merged 28 commits into
mainfrom
xsalonx/export/O2B-1462/all-qc-flag-export

Conversation

@xsalonx

@xsalonx xsalonx commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Allow to include QC flags for given data pass, simulation pass or LHC period when fetching runs

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Aug 4, 2025
@xsalonx xsalonx changed the title Xsalonx/export/o2 b 1462/all qc flag export [O2B-1462] Etend runs APIT to include QC flags Aug 4, 2025
@xsalonx xsalonx changed the title [O2B-1462] Etend runs APIT to include QC flags [O2B-1462] Extend runs APIT to include QC flags Aug 4, 2025
@xsalonx xsalonx changed the title [O2B-1462] Extend runs APIT to include QC flags [O2B-1462] Extend runs API to include QC flags Aug 4, 2025
@xsalonx xsalonx added the backend label Aug 4, 2025
@codecov

codecov Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.94%. Comparing base (8393baa) to head (160ce7a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/domain/dtos/utils.js 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
+ Coverage   41.30%   45.94%   +4.64%     
==========================================
  Files        1014     1015       +1     
  Lines       16757    16790      +33     
  Branches     3026     3038      +12     
==========================================
+ Hits         6921     7714     +793     
+ Misses       9836     9076     -760

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx marked this pull request as ready for review August 4, 2025 10:31
@xsalonx xsalonx requested a review from graduta as a code owner August 4, 2025 10:31
graduta
graduta requested changes Aug 4, 2025
View reviewed changes
Comment thread lib/domain/dtos/GetAllRunsDto.js Outdated
@xsalonx xsalonx requested a review from graduta August 4, 2025 14:13
@xsalonx xsalonx merged commit df49e39 into main Aug 4, 2025
40 of 41 checks passed
@xsalonx xsalonx deleted the xsalonx/export/O2B-1462/all-qc-flag-export branch August 4, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

Assignees

@xsalonx xsalonx

Labels

backend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xsalonx @graduta